[PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

[Vedant Kumar via cfe-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Serialization/ASTReaderDecl.cpp:154
@@ -153,3 +153,3 @@
     public:
-      RedeclarableResult(GlobalDeclID FirstID, Decl *MergeWith, bool IsKeyDecl)
-          : FirstID(FirstID), MergeWith(MergeWith), IsKeyDecl(IsKeyDecl) {}
+      RedeclarableResult(Decl *MergeWith, GlobalDeclID FirstID, bool IsKeyDecl)
+          : MergeWith(MergeWith), FirstID(FirstID), IsKeyDecl(IsKeyDecl) {}
----------------
alexshap wrote:
> vsk wrote:
> > Why do you need to change the order of the parameters in the constructor?
> To avoid inconsistency. Here the parameters match the fields and it seemed to me that it would be better to update the order. 
OK. But why not do the same thing for ObjCCategoriesVisitor?


Repository:
  rL LLVM

https://reviews.llvm.org/D24754