[PATCH] D24803: [change-namespace] fix qualifier of function references.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 22 01:40:41 PDT 2016


hokein added inline comments.

================
Comment at: change-namespace/ChangeNamespace.cpp:290
@@ +289,3 @@
+  // namespace.
+  // Note that the matcher does not exlude calls to out-of-line static method
+  // definitions, so we need to exclude them in the callback handler.
----------------
s/exlude/exclude.

================
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:317
@@ -316,1 +316,3 @@
 
+TEST_F(ChangeNamespaceTest, FixFunctionNameSpecifiers) {
+  std::string Code =
----------------
Add a test for the case you mentioned in above?

> // Ignore static methods since they will be handled by nested name specifiers.


https://reviews.llvm.org/D24803





More information about the cfe-commits mailing list