[PATCH] D24679: [libc++] Fix extern template visibility for Windows
Saleem Abdulrasool via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 19 11:10:53 PDT 2016
compnerd added inline comments.
================
Comment at: include/__config:559
@@ -554,1 +558,3 @@
+# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS
+# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS
#endif
----------------
Does it make sense for `_LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS` to ever be marked as `__declspec(dllimport)`? The macro is applied on instantiations in the implementation, not the header, so this shouldn't be visible to users.
https://reviews.llvm.org/D24679
More information about the cfe-commits
mailing list