[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

Daphne Pfister via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 18 11:53:17 PDT 2016


daphnediane added a comment.

In https://reviews.llvm.org/D24703#545706, @djasper wrote:

> I think, this is the wrong fix. Instead, a
>
>   || (Left.is(TT_TemplateOpener) && !Right.is(TT_TemplateCloser))
>   
>
> should be added to the last return statement of this function.
>
> Also, could you please add a test in unittests/Format/FormatTest.cpp.


Trying that on my code after I finish rebasing and rebuilding, will also look into adding test to FormatTest.


https://reviews.llvm.org/D24703





More information about the cfe-commits mailing list