[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

Daniel Jasper via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 17 22:48:36 PDT 2016

Previous message: r281845 - [libFuzzer] use 'if guard' instead of 'if guard >= 0' with trace-pc; change the guard type to intptr_t; use separate array for 8-bit counters
Next message: [PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

djasper added a comment.

I think, this is the wrong fix. Instead, a

  || (Left.is(TT_TemplateOpener) && !Right.is(TT_TemplateCloser))

should be added to the last return statement of this function.

Also, could you please add a test in unittests/Format/FormatTest.cpp.


https://reviews.llvm.org/D24703

Previous message: r281845 - [libFuzzer] use 'if guard' instead of 'if guard >= 0' with trace-pc; change the guard type to intptr_t; use separate array for 8-bit counters
Next message: [PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list