[PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

Philippe Daouadi via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 16 12:42:47 PDT 2016


blastrock added inline comments.

================
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:9
@@ -8,3 +8,3 @@
 // This test is too subtle to try on non-x86 arch for now.
-// REQUIRES: x86_64-supported-target,i386-supported-target
+// REQUIRES: x86-target-arch
 
----------------
andriigrynenko wrote:
> The test was actually broken in trunk (not updated for the fakestack argument). Apparently it was never run (considered unsupported) because of wrong targets here. 
Indeed, my bad, I forgot to compile and run the tests after the last modification I made to that patch. Sorry for that.

I didn't need to change this line to run them on my computer though, but if you know what you are doing with this line, it's ok. And it's strange indeed that no buildfarm caught this...


https://reviews.llvm.org/D24628





More information about the cfe-commits mailing list