[PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

[Haojian Wu via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

The patch looks good to me now.


================
Comment at: change-namespace/ChangeNamespace.h:44
@@ +43,3 @@
+class ChangeNamespaceTool : ast_matchers::MatchFinder::MatchCallback {
+public:
+  // Moves code in the old namespace `OldNs` to the new namespace `NewNs` in
----------------
You forgot this one.

================
Comment at: change-namespace/ChangeNamespace.h:101
@@ +100,3 @@
+  std::string FallbackStyle;
+  std::map<std::string, tooling::Replacements> &FileToReplacements;
+  // A fully qualified name of the old namespace without "::" prefix, e.g.
----------------
Would be clearer to add comment describing the kinds of these replacements (e.g. deleting the forward declarations, replacing the old qualifiers with the new shortest qualified name).


https://reviews.llvm.org/D24183