[PATCH] D24446: Implement revision to LWG#2758

[Eric Fiselier via cfe-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

The new overloads taking string_view's need to guard against self-aliasing string_views. Once that is fixed I would double check that your tests for `!is_convertible<_Tp const&, const _CharT*>` still work.

Other than that this LGTM.


================
Comment at: include/string:613
@@ +612,3 @@
+	( is_convertible<const _Tp&, basic_string_view<_CharT, _Traits> >::value &&
+     !is_convertible<const _Tp&, const _CharT*>::value)) {};
+
----------------
The discussion for LWG 2758 gives a `replace` test case for this condition. Could you add that test to our suite?


https://reviews.llvm.org/D24446