Upgrade and fix clang-format-vs

[Zachary Turner via cfe-commits]

You may need to install the Visual Studio SDK.  Did you do that when you
initially installed VS 2015?

On Thu, Sep 15, 2016 at 4:15 PM Hans Wennborg <hans at chromium.org> wrote:

> Well, on my machine $(SDKToolsDir) doesn't work :-( I suspect the file
> will need manual tweaking by whoever is trying to build the plugin.
>
> Anyway, I've updated the solution to build with VS2015 in r281648 and
> confirmed that it can still be used with older VS versions too.
>
> Cheers,
> Hans
>
> On Thu, Aug 18, 2016 at 7:11 PM, Zachary Turner <zturner at google.com>
> wrote:
> > The key.snk is generated when you build, the problem is the csproj file
> > hardcodes the directory to the sdk instead of using the appropriate
> project
> > system variable like $(SDKToolsDir)
> >
> > On Thu, Aug 18, 2016 at 7:09 PM Zachary Turner <zturner at google.com>
> wrote:
> >>
> >> Llvm doesn't support vs2012 anymore, as long as it supports vs2013 it's
> >> fine
> >> On Thu, Aug 18, 2016 at 7:07 PM Antonio Maiorano <amaiorano at gmail.com>
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>> What I meant by upgrade was simply making it build in VS 2015. However,
> >>> you bring up a valid point about making sure the extension will
> continue to
> >>> work in VS 2012. I will look into that. Like those references that go
> from
> >>> 10 to 14 that point out; I wonder if instead I should be able to bring
> in
> >>> those version 10 assemblies via NuGet. I'll take a closer look.
> >>>
> >>> Part of my change, however, seems to imply that the extension (vsix)
> >>> project would not build correctly even in VS 2012. For instance, the
> missing
> >>> Key.snk file. I don't have VS 2012 installed at the moment, so I cannot
> >>> validate.
> >>>
> >>> Thanks,
> >>>
> >>> Antonio
> >>>
> >>>
> >>>
> >>> On Thu, 18 Aug 2016 at 19:38 Hans Wennborg <hans at chromium.org> wrote:
> >>>>
> >>>> Hi Antonio,
> >>>>
> >>>> On Wed, Aug 17, 2016 at 8:15 AM, Antonio Maiorano via cfe-commits
> >>>> <cfe-commits at lists.llvm.org> wrote:
> >>>> > This patch for clang-format-vs includes the following:
> >>>> >
> >>>> > - Upgrade to VS 2015, including .NET framework upgrade from 4.0 to
> >>>> > 4.5, and
> >>>> > upgrading Microsoft.VisualStudio references to v14 versions
> >>>> > - Fix build by removing dependency on "Key.snk" file which was never
> >>>> > checked
> >>>> > in (and not really required anyway)
> >>>> > - Add ".vs" directory to svn ignore (new folder that VS 2015 creates
> >>>> > for
> >>>> > user settings)
> >>>>
> >>>> "What does "Upgrade to VS 2015 mean? Adding support for running the
> >>>> plugin in VS2015, or does it mean requiring VS2015 for building?
> >>>>
> >>>> +zturner: I thought the plugin already worked in VS 2015?
> >>>>
> >>>> I mostly just build the plugin without knowing exactly how this stuff
> >>>> works, but looking at the patch I'm worried that you're increasing the
> >>>> required version for building it? I see a bunch of values going from
> >>>> 10 (VS 2012) to 14 (VS 2015).
> >>>>
> >>>> Thanks,
> >>>> Hans
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160915/0eb815e4/attachment.html>