[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 15 02:28:46 PDT 2016


rmaprath added inline comments.

================
Comment at: test/std/re/re.alg/re.alg.search/grep.pass.cpp:25
@@ -25,2 +24,3 @@
 
+#ifndef TEST_HAS_NO_EXCEPTIONS
 extern "C" void LLVMFuzzerTestOneInput(const char *data)
----------------
EricWF wrote:
> I prefer putting the `#if` on the inside of the function so you don't also have to `#ifdef` it out in `main()` below. 
> 
Thanks. That's much better.

I'll convert as much tests as possible and submit and overall patch for a final review.


https://reviews.llvm.org/D24562





More information about the cfe-commits mailing list