[PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

Kevin Funk via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 15 02:11:24 PDT 2016


kfunk added a comment.

@other LLVM devs: Please review so we can finally ship this?


================
Comment at: tools/libclang/CIndex.cpp:4311
@@ -4311,1 +4310,3 @@
+      C.kind == CXCursor_ConversionFunction ||
+      C.kind == CXCursor_FunctionDecl) {
     if (pieceIndex > 0)
----------------
skalinichev wrote:
> What about function templates?
> 
> E.g.: template <char...> double operator "" _x();
Still broken for function template. The fix isn't as easy as adding another check for `C.kind == CXCursor=FunctionTemplate`, though.

We should fix this in another patch.


https://reviews.llvm.org/D18462





More information about the cfe-commits mailing list