[PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

Alexander Shaposhnikov via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 13 12:25:54 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL281373: [analyzer] Fix ExprEngine::VisitMemberExpr (authored by alexshap).

Changed prior to commit:
  https://reviews.llvm.org/D24484?vs=71082&id=71218#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D24484

Files:
  cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
  cfe/trunk/test/Analysis/array-struct.c

Index: cfe/trunk/test/Analysis/array-struct.c
===================================================================
--- cfe/trunk/test/Analysis/array-struct.c
+++ cfe/trunk/test/Analysis/array-struct.c
@@ -135,6 +135,17 @@
 
 void bar(int*);
 
+struct s3 gets3() {
+  struct s3 s;
+  return s;
+}
+
+void accessArrayFieldNoCrash() {
+  bar(gets3().a);
+  bar((gets3().a));
+  bar(((gets3().a)));  
+}
+
 // Test if the array is correctly invalidated.
 void f15() {
   int a[10];
Index: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
===================================================================
--- cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
+++ cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
@@ -2044,7 +2044,7 @@
         if (!M->isGLValue()) {
           assert(M->getType()->isArrayType());
           const ImplicitCastExpr *PE =
-            dyn_cast<ImplicitCastExpr>((*I)->getParentMap().getParent(M));
+            dyn_cast<ImplicitCastExpr>((*I)->getParentMap().getParentIgnoreParens(M));
           if (!PE || PE->getCastKind() != CK_ArrayToPointerDecay) {
             llvm_unreachable("should always be wrapped in ArrayToPointerDecay");
           }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24484.71218.patch
Type: text/x-patch
Size: 1177 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160913/102adb82/attachment-0001.bin>


More information about the cfe-commits mailing list