[PATCH] D24469: [clang-cl] Diagnose duplicate uuids.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 13 11:20:48 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.

LGTM!


================
Comment at: lib/Sema/SemaDeclAttr.cpp:4609
@@ +4608,3 @@
+                              unsigned AttrSpellingListIndex, StringRef Uuid) {
+  if (const auto *UA = D->getAttr<UuidAttr>()) {
+    if (UA->getGuid() == Uuid)
----------------
I didn't pick up on the fact that there shouldn't be multiple UUID attributes associated with a single decl anyway. So this code is fine (with the auto nit fixed).


https://reviews.llvm.org/D24469





More information about the cfe-commits mailing list