[PATCH] D23820: Do not warn about format strings that are indexed string literals.

Meike Baumgärtner via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 12 12:46:45 PDT 2016


meikeb marked 4 inline comments as done.

================
Comment at: lib/Sema/SemaChecking.cpp:4166-4167
@@ +4165,4 @@
+    if (BinOp->isAdditiveOp()) {
+      bool LIsInt = false;
+      bool RIsInt = false;
+      // Prevent asserts triggering in EvaluateAsInt by checking if we deal with
----------------
I hope this additional check fixes this issue. As far as I read the code there were none such asserts in isIntegerConstantExpr(). Thanks for explaining this!


https://reviews.llvm.org/D23820





More information about the cfe-commits mailing list