[PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

[Marshall Clow via cfe-commits]

mclow.lists added a comment.

This all looks good to me - but with a couple nits.


================
Comment at: include/memory:2137
@@ -2132,3 +2136,3 @@
 
-    _LIBCPP_INLINE_VISIBILITY
+    _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR
     __libcpp_compressed_pair_imp& operator=(__libcpp_compressed_pair_imp&& __p)
----------------
Have you tested this on C++11?
I suspect that some of these need to be `_LIBCPP_CONSTEXPR_AFTER_CXX11`

================
Comment at: test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/constinit.pass.cpp:16
@@ +15,3 @@
+#ifndef _LIBCPP_SAFE_STATIC
+#define _LIBCPP_SAFE_STATIC
+#endif
----------------
Shouldn't this test be in the `libcxx` hierarchy, since it uses internal libcxx features (i.e, `_LIBCPP_SAFE_STATIC`)?


Repository:
  rL LLVM

https://reviews.llvm.org/D24372