[PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

[Kirill Bobyrev via cfe-commits]

omtcyfz added a comment.

Ping.


================
Comment at: clang-rename/USRFindingAction.cpp:169
@@ -160,2 +168,3 @@
                << SymbolOffset << ").\n";
+        exit(1);
       } else {
----------------
alexfh wrote:
> I'd better not use `exit()` in library code and try to find a way to signal the error to the caller (e.g. make the function return a bool so that HandleTranslationUnit doesn't do useless work, and use ASTContext::getDiagnostics() to report errors; or add a separate callback, if this doesn't work for some reason).
Done.


https://reviews.llvm.org/D24224