[PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 8 14:28:09 PDT 2016


rnk added a comment.

I was thinking of suggesting to put it under -Wextra, but -Wall is fine too.

I still don't think it should be on by default. I think there are a lot of Unix-only projects out there that aren't concerned with MSVC compatibility, and a warning about how things with in the Microsoft ABI would be surprising and noisy. Maybe we could tack on "... to make this code portable" or something to the diagnostic text to make it more clear why the user should be concerned about this?


https://reviews.llvm.org/D24289





More information about the cfe-commits mailing list