[PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 8 11:54:46 PDT 2016


aaron.ballman added inline comments.

================
Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:34
@@ +33,3 @@
+  const auto *Construct = Result.Nodes.getNodeAs<CXXConstructExpr>("construct");
+  const auto arguments = Construct->arguments();
+
----------------
sbenza wrote:
> Prazek wrote:
> > Arguments (upper case)
> Arguments variable name. (should start with upper case)
Please do not use `auto` here, since the type is not spelled out in the initializer.

================
Comment at: clang-tidy/readability/RedundantMemberInitCheck.h:19
@@ +18,3 @@
+
+/// Find unnecessary member initializers
+///
----------------
What makes one unnecessary? Also, missing a full stop at the end of the sentence.


Repository:
  rL LLVM

https://reviews.llvm.org/D24339





More information about the cfe-commits mailing list