[clang-tools-extra] r280844 - Fix a few oversights in the clang-tidy VS plugin.

[Zachary Turner via cfe-commits]

Author: zturner
Date: Wed Sep  7 14:41:19 2016
New Revision: 280844

URL: http://llvm.org/viewvc/llvm-project?rev=280844&view=rev
Log:
Fix a few oversights in the clang-tidy VS plugin.

Over-zealous cleanup of using statements removed some that were
actually needed.  Also cleaned up a few warnings.

Modified:
    clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckDatabase.cs
    clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckTree.cs
    clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs
    clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs

Modified: clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckDatabase.cs
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckDatabase.cs?rev=280844&r1=280843&r2=280844&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckDatabase.cs (original)
+++ clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckDatabase.cs Wed Sep  7 14:41:19 2016
@@ -50,7 +50,7 @@ namespace LLVM.ClangTidy
                 foreach (var Check in Checks_)
                 {
                     if (Names.Contains(Check.Name))
-                        throw new ArgumentException(String.Format("Check {0} exists more than once!", Check.Name));
+                        continue;
                     Names.Add(Check.Name);
                 }
             }

Modified: clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckTree.cs
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckTree.cs?rev=280844&r1=280843&r2=280844&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckTree.cs (original)
+++ clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/CheckTree.cs Wed Sep  7 14:41:19 2016
@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.ComponentModel;
+using System.Linq;
 using System.Text;
 
 namespace LLVM.ClangTidy

Modified: clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs?rev=280844&r1=280843&r2=280844&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs (original)
+++ clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyProperties.cs Wed Sep  7 14:41:19 2016
@@ -40,7 +40,6 @@ namespace LLVM.ClangTidy
         static ClangTidyProperties()
         {
             RootProperties_ = new ClangTidyProperties(null);
-            PropertyDescriptor D;
         }
 
         public static ClangTidyProperties RootProperties

Modified: clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs?rev=280844&r1=280843&r2=280844&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs (original)
+++ clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs Wed Sep  7 14:41:19 2016
@@ -42,13 +42,6 @@ namespace LLVM.ClangTidy
         /// </summary>
         List<KeyValuePair<string, ClangTidyProperties>> PropertyChain_ = null;
 
-        /// <summary>
-        /// A tree representing all the checks that the extension knows about, used
-        /// when serializing a file to intelligently determine when to use wildcard
-        /// include / exclude rules.
-        /// </summary>
-        CheckTree Checks_;
-
         public ClangTidyPropertyGrid()
         {
             InitializeComponent();