[PATCH] D24087: [lit] Allow more file extensions for test cases.

[Eric Fiselier via cfe-commits]

EricWF added inline comments.

================
Comment at: test/libcxx/test/format.py:69
@@ +68,3 @@
+        name_root, name_ext = os.path.splitext(name)
+        is_sh_test = name_root.endswith('.sh')
+        is_pass_test = name_root.endswith('.pass')
----------------
logan wrote:
> EricWF wrote:
> > Since we only support `.sh.XXX` tests let's only loosen the restriction there for now.
> Do you mean that it is preferred to revert following two lines back?  For example:
> 
>     is_sh_test = name_root.endswith('.sh')
>     is_pass_test = name.endswith('.pass.cpp')
>     is_fail_test = name.endswith('.fail.cpp')
>     assert is_sh_test or name_ext == '.cpp'
Yeah. Leave a FIXME about `CXXCompiler` not supporting assembly if you want. 


https://reviews.llvm.org/D24087