[PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Andi via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 3 02:20:18 PDT 2016


Abpostelnicu added inline comments.

================
Comment at: lib/AST/Expr.cpp:2869
@@ +2868,3 @@
+    OverloadedOperatorKind Op = cast<CXXOperatorCallExpr>(this)->getOperator();
+    if (CXXOperatorCallExpr::isAssignmentOp(Op)) {
+      const Decl *FD = cast<CallExpr>(this)->getCalleeDecl();
----------------
aaron.ballman wrote:
> Should this also handle overloaded ++ and -- if they're the prefix forms? What about overloaded operator new and delete (and the array forms)?
I think for now i should prefer only to have the implementation for assignment operator when it's overloaded.


https://reviews.llvm.org/D22910





More information about the cfe-commits mailing list