[PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

[Richard Smith via cfe-commits]

rsmith accepted this revision.
rsmith added a comment.

For submit, can you separate the changes to generally support `[]` attribute syntax and the changes to parse `[uuid(...)]` into distinct commits? (I'm OK with the `Microsoft` attribute support piece landing with no tests since the `uuid` patch adds the relevant testing -- and I believe that piece by itself is NFC.)


================
Comment at: test/Parser/ms-square-bracket-attributes.mm:129-131
@@ +128,5 @@
+  int uuid = 42;
+  [uuid]() {
+    useit(uuid);
+  }();
+}
----------------
Please also test cases like

  [uuid(00000000-0000-0000-0000-000000000000)] { return uuid; }
  [uuid("00000000-0000-0000-0000-000000000000")] (int n) { return uuid[n]; }

(which are lambda *init-capture*s in C++14 onwards).


https://reviews.llvm.org/D23895