[PATCH] D24054: Do not validate pch when -fno-validate-pch is set

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 2 09:33:02 PDT 2016


yaxunl added a comment.

The bug is due to PCHValidator is added as Listener, which causes pch is validated even though DisableValidation is true (when -fno-validate-pch is on). The fix is not add PCHValidator as listener when DisableValidation is true.

The bug is annoying for using pch. When pch is generated with default optimization, the generated pch cannot be used to compile program with -O0.

Tom/Alexey, can you help review the code? Thanks.


https://reviews.llvm.org/D24054





More information about the cfe-commits mailing list