[PATCH] D24192: [clang-refactor] introducing clang-refactor

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 2 09:08:10 PDT 2016


ioeric added a comment.

- You mentioned a design doc in the summary; maybe also include a link to it?
- It would make the review easier if you could separate the migration of clang-rename into another patch...I think clang-refactor is really the interesting part here. And maybe also add a small dummy sub-module as an example demonstrating how to add a new sub-module, which I believe will be helpful for future developers. (See also tool-template <https://github.com/llvm-mirror/clang-tools-extra/tree/master/tool-template> which exists for the same purpose.)


================
Comment at: TemplatedClassFunction.cpp:1
@@ +1,2 @@
+template <typename T>
+class A {
----------------
What is this file for?


https://reviews.llvm.org/D24192





More information about the cfe-commits mailing list