[PATCH] D24152: Support the overloadable attribute with _Generic expressions

[Aaron Ballman via cfe-commits]

aaron.ballman added inline comments.

================
Comment at: lib/Sema/SemaOverload.cpp:12996
@@ +12995,3 @@
+      // selection expression.
+      std::vector<Expr *> AssocExprs(GSE->getAssocExprs().vec());
+      unsigned ResultIdx = GSE->getResultIndex();
----------------
dblaikie wrote:
> george.burgess.iv wrote:
> > Is there a reason this isn't a `SmallVector` instead?
> Another note on this - we should generally prefer copy init over direct init (less power, less responsibility/easier to read):
> 
>   std::vector<Expr*> AssocExprs = GSE->getAssocExprs().vec();
> 
> (& as for George's question: since ArrayRef::vec returns std::vector, it's cheaper to store in a std::vector (by move) than to make a copy into a SmallVector)
Yeah, I originally used std::vector<> because of ArrayRef's interface. I am happy to go either route, depending on preference, as I doubt this will wind up on the hot path with any regularity.


https://reviews.llvm.org/D24152