[PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

[Kirill Bobyrev via cfe-commits]

omtcyfz added inline comments.

================
Comment at: change-namespace/ChangeNamespace.cpp:21
@@ +20,3 @@
+inline std::string formatNamespace(llvm::StringRef NS) {
+  (void)NS.ltrim(':');
+  return NS.str();
----------------
is `(void)` intended here?

================
Comment at: change-namespace/ChangeNamespace.h:41
@@ +40,3 @@
+//   }  // x
+// TODO(ioeric): support moving typedef, enums across namespaces.
+class ChangeNamespaceTool : ast_matchers::MatchFinder::MatchCallback {
----------------
`FIXME`?


Repository:
  rL LLVM

https://reviews.llvm.org/D24183