[PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

Jonathan Roelofs via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 1 17:20:29 PDT 2016


jroelofs added a comment.

In https://reviews.llvm.org/D21803#532382, @EricWF wrote:

> In https://reviews.llvm.org/D21803#532347, @jroelofs wrote:
>
> > In https://reviews.llvm.org/D21803#532309, @EricWF wrote:
> >
> > > `__thread`
> > >
> > > What do you think of this idea?
> >
> >
> > You'll have to guard it against all the platforms that don't support TLS. Darwin 10.6 is one of them.
>
>
> Which is fine because we shouldn't supply a definition of `__cxa_thread_atexit` on those platforms.


Ah, ok. Sounds good.


https://reviews.llvm.org/D21803





More information about the cfe-commits mailing list