[PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 1 13:35:26 PDT 2016


rsmith added inline comments.

================
Comment at: include/clang/Basic/Attr.td:201
@@ -200,2 +200,3 @@
 class Declspec<string name> : Spelling<name, "Declspec">;
+class Microsoft<string name> : Spelling<name, "Microsoft">;
 class CXX11<string namespace, string name, int version = 1>
----------------
Given that MS have deprecated this syntax and are trying to move away from it towards `__declspec`, I think calling this "Microsoft" is a mistake. As MS' documentation calls these "ATL attributes", it would seem reasonable for us to do the same.


https://reviews.llvm.org/D23895





More information about the cfe-commits mailing list