[PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

[Anna Zaks via cfe-commits]

zaks.anna added a comment.

I've added kcc as a reviewer to see what his opinion is.

The way I see this, is that the sanitizer flags and the -nodefaultlibs and -nostdlib flags are not fully compatible since sanitizers will not work for some users who explicitly pass the "-no*" flags.

libcxx happens to work, however, it's just one of the users and it has a much better representation on this list since it's an LLVM project. I do not think this is a blocker for sanitizing libcxx because we could change the build system to explicitly link in the ASan library, correct?

In any case, we would need some type of diagnostic in the driver to notify the user about the incompatibility. We just need to decide which default to pick.


https://reviews.llvm.org/D24048