[PATCH] D23918: [clang-tidy docs] Add missing option docs.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 31 05:57:20 PDT 2016


hokein added inline comments.

================
Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21
@@ +20,3 @@
+   extensions should not include "." prefix). Default is "h,hh,hpp,hxx".
+   For header files without an extension, use an empty string (if there are no
+   other desired extensions) or leave an empty element in the list. e.g.,
----------------
aaron.ballman wrote:
> I may be confused then -- does the string "h,hh,hpp,hxx" (no trailing comma) also wind up including header files without extensions? If so, we should document that. If not, would adding a trailing comma cause it to include header files without an extension? If so, that's what my example was trying to point out, but perhaps my phrasing needs clarifying.
Aha, sorry, I misunderstood your words here. Yeah, we should add trailing `,` for the non-extension headers. 


https://reviews.llvm.org/D23918





More information about the cfe-commits mailing list