[PATCH] D23918: [clang-tidy docs] Add missing option docs.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 31 05:42:06 PDT 2016


aaron.ballman added inline comments.

================
Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21
@@ +20,3 @@
+   extensions should not include "." prefix). Default is "h,hh,hpp,hxx".
+   For header files without an extension, use an empty string (if there are no
+   other desired extensions) or leave an empty element in the list. e.g.,
----------------
I may be confused then -- does the string "h,hh,hpp,hxx" (no trailing comma) also wind up including header files without extensions? If so, we should document that. If not, would adding a trailing comma cause it to include header files without an extension? If so, that's what my example was trying to point out, but perhaps my phrasing needs clarifying.

================
Comment at: docs/clang-tidy/checks/misc-sizeof-expression.rst:154
@@ +153,2 @@
+   ``sizeof(epxr) <= k`` for a suspicious constant `k` while `k` is `0` or
+   bigger than `0x8000`. Default is `1`.
----------------
s/bigger than/greater than

================
Comment at: docs/clang-tidy/checks/performance-for-range-copy.rst:26
@@ +25,3 @@
+
+   When non-zero, warns on any use of auto as the type of the range-based for
+   loop variable. Default is `0`.
----------------
Should quote auto with backtics, I suppose.


https://reviews.llvm.org/D23918





More information about the cfe-commits mailing list