r280104 - Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating.

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 30 23:09:48 PDT 2016


On 30 Aug 2016 4:05 pm, "NAKAMURA Takumi" <geek4civic at gmail.com> wrote:

Thanks, Richard.

Conversely, do we need to give sufficient amount of stack to the clang
executable whenever this fails?

By default, clang.exe has 2MiB (and *-tblgen.exe(s) are gaven 16MiB) of
stack on mingw-w64. 10,000,000 bytes on MS-compiled executables. I can
easily increase the size.


Clang expects 8MB (we reserve this much from cc1_main when we know how, and
create per-thread stacks of this size when building modules or when
libclang does background parsing). Making this consistent across build
environments seems like a good idea.

See HandleLLVMOptions.cmake and TableGen.cmake.

On Wed, Aug 31, 2016 at 4:12 AM Richard Smith <richard at metafoo.co.uk> wrote:

> On Tue, Aug 30, 2016 at 8:38 AM, NAKAMURA Takumi via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
>> Author: chapuni
>> Date: Tue Aug 30 10:38:18 2016
>> New Revision: 280104
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=280104&view=rev
>> Log:
>> Disable clang/test/SemaTemplate/instantiation-depth-default.cpp
>> temporarily for targeting mingw32. It crashes. Investigating.
>>
>
> This is probably due to stack overflow. Is there a way we can raise the
> stack limit for mingw32?
>
>
>> Modified:
>>     cfe/trunk/test/SemaTemplate/instantiation-depth-default.cpp
>>
>> Modified: cfe/trunk/test/SemaTemplate/instantiation-depth-default.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/
>> SemaTemplate/instantiation-depth-default.cpp?rev=280104&
>> r1=280103&r2=280104&view=diff
>> ============================================================
>> ==================
>> --- cfe/trunk/test/SemaTemplate/instantiation-depth-default.cpp
>> (original)
>> +++ cfe/trunk/test/SemaTemplate/instantiation-depth-default.cpp Tue Aug
>> 30 10:38:18 2016
>> @@ -12,3 +12,6 @@ template<int N, typename T> struct X : X
>>  // expected-note at 8 {{use -ftemplate-depth=N to increase recursive
>> template instantiation depth}}
>>
>>  X<0, int> x; // expected-note {{in instantiation of}}
>> +
>> +// FIXME: It crashes. Investigating.
>> +// UNSUPPORTED: mingw32
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160830/6740eacb/attachment.html>


More information about the cfe-commits mailing list