[PATCH] D23279: clang-reorder-fields

[Alexander Shaposhnikov via cfe-commits]

alexshap added inline comments.

================
Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:179
@@ +178,3 @@
+    const ASTContext &Context,
+    std::map<std::string, tooling::Replacements> &Replacements) {
+  assert(InitListEx && "Init list expression is null");
----------------
>Also, I don't understand what the problem is. Just create separate local variable for >Replacements and only copy to the class member if everything is successful. Or clear >Replacements if something goes wrong. Am I missing something?
the return code. I assumed that in this case the return code should not be 0, but pls take a look at my comments above (regarding the signature of HandleTranslationUnit and http://clang.llvm.org/doxygen/CompilerInstance_8cpp_source.html#l00871
line 871  Act.Execute();     (return value is ignored) ) it looks like the return code is ignored at several layers - i might be missing smth  - pls, correct me if i am wrong.


Repository:
  rL LLVM

https://reviews.llvm.org/D23279