[PATCH] D23746: Basic/Targets.cpp: Add polaris10 and polaris11 gpus

Niels Ole Salscheider via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 27 07:02:59 PDT 2016


olesalscheider added inline comments.

================
Comment at: lib/Basic/Targets.cpp:1959
@@ -1959,1 +1958,3 @@
+    GK_VOLCANIC_ISLANDS,
+    GK_ARCTIC_ISLANDS
   } GPU;
----------------
arsenm wrote:
> tstellarAMD wrote:
> > We're trying to move to more descriptive GPU family names, so this should be GK_GFX8 instead of GK_ARCTIC_ISLANDS.  GK_VOLCANIC_ISLANDS should also be changed to GK_GFX8, but that can be done in another patch, and would not be a prerequisite for this patch. 
> For now I think polaris10/11 should just be left as VOLCANIC_ISLANDS
Ok... I'll leave it as VOLCANIC_ISLANDS and propose a follow-up patch that replaces all GCN names then.


https://reviews.llvm.org/D23746





More information about the cfe-commits mailing list