[PATCH] D23279: clang-reorder-fields

[Alexander Shaposhnikov via cfe-commits]

alexshap marked 2 inline comments as done.

================
Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:202
@@ +201,3 @@
+    for (const auto *C : RD->ctors()) {
+      if (C->isImplicit() || C->isDelegatingConstructor())
+        continue;
----------------
djasper wrote:
> Why are you ruling out delegating constructors?
./include/clang/Basic/DiagnosticSemaKinds.td:1961:  "an initializer for a delegating constructor must appear alone";
So i assumed that right now we don't need to do anything with them.
Please, correct me if i am wrong. Anyway, good question.

================
Comment at: clang-reorder-fields/tool/ClangReorderFields.cpp:68
@@ +67,3 @@
+
+  int ExitCode = Tool.run(Factory.get());
+  LangOptions DefaultLangOptions;
----------------
djasper wrote:
> Should you continue if the exit code isn't 0 here?
the mode dumping changes to stdout & using text diagnostics) seems to be useful to for debugging / testing. I can simply return ExitCode, but probably that's not very convenient. 


Repository:
  rL LLVM

https://reviews.llvm.org/D23279