[PATCH] D23848: Add a clang-tidy Visual Studio extension

[Adrian McCarthy via cfe-commits]

amccarth added a comment.

I don't know enough C# to review for language usage.  I was mostly reading for understandability.  Overall, I think this looks really nice.


================
Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:67
@@ +66,3 @@
+                if (ParentPath == null)
+                    return Name_;
+                return ParentPath + "-" + Name_;
----------------
This seems overly complicated so I assume I'm missing some nuance.  Why not:

    if (Parent_ == null)
        return Name_;
    string ParentPath = Parent_.Path;

Is there a case where Parent_.Path could return null besides the one that you created?



================
Comment at: clang-tidy-vs/ClangTidy/InheritablePropertyComponent.cs:14
@@ +13,3 @@
+    /// have properties which might inherit from their parent, or be overridden.
+    /// It turns out this is somewhat non-trivial.  The .NET PropertyGrid is good makes
+    /// displaying simple properties with a static notion of what constitutes a
----------------
s/good makes/makes/


================
Comment at: clang-tidy-vs/README.txt:8
@@ +7,3 @@
+- Visual Studio 2010 Professional (?)
+- Visual Studio 2010 SDK (?)
+
----------------
2010?  2015?  Will Community editions work?


https://reviews.llvm.org/D23848