[PATCH] D23279: clang-reorder-fields
Alexander Shaposhnikov via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 24 15:12:49 PDT 2016
alexshap updated this revision to Diff 69174.
alexshap added a comment.
Address @djasper 's comments
1. Add brief comments to the helper functions.
2. Get rid of the workaround.
(https://reviews.llvm.org/D23828 has been merged in and i have rebased on the latest revision)
3. Made stylistic / name conventions adjustments
I have not addressed the comment regarding printing the "help message" in the main() function yet -
will take a look at it.
Please, let me know if i have missed something critical.
Repository:
rL LLVM
https://reviews.llvm.org/D23279
Files:
CMakeLists.txt
clang-reorder-fields/CMakeLists.txt
clang-reorder-fields/ReorderFieldsAction.cpp
clang-reorder-fields/ReorderFieldsAction.h
clang-reorder-fields/tool/CMakeLists.txt
clang-reorder-fields/tool/ClangReorderFields.cpp
test/CMakeLists.txt
test/clang-reorder-fields/CStructAmbiguousName.cpp
test/clang-reorder-fields/CStructFieldsOrder.cpp
test/clang-reorder-fields/ClassMixedInitialization.cpp
test/clang-reorder-fields/ClassSimpleCtor.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23279.69174.patch
Type: text/x-patch
Size: 20146 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160824/1b95cd56/attachment-0001.bin>
More information about the cfe-commits
mailing list