[PATCH] D21134: clang-tidy: new check readability-misplaced-array-index
Daniel Marjamäki via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 24 06:54:33 PDT 2016
danielmarjamaki marked 6 inline comments as done.
================
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:57
@@ +56,2 @@
+} // namespace tidy
+} // namespace clang
----------------
I removed hasMacroId() and use fixit::getText(). The replacements look good now.
================
Comment at: docs/clang-tidy/checks/readability-misplaced-array-index.rst:13
@@ +12,3 @@
+ void f(int *x, int y) {
+ y[x] = 0;
+ }
----------------
ok thanks same mistake I've done before. Should I start using uppercase variable names from now on?
https://reviews.llvm.org/D21134
More information about the cfe-commits
mailing list