[PATCH] D23279: clang-reorder-fields

Alexander Shaposhnikov via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 23 23:36:42 PDT 2016


alexshap added inline comments.

================
Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:152
@@ +151,3 @@
+  // SourceLocation::isValid is const.
+  if (!const_cast<clang::InitListExpr *>(InitListEx)->isExplicit() ||
+      !InitListEx->getNumInits())
----------------
djasper wrote:
> I think it is an oversight that isExplicit() isn't const. Can you send out a separate patch to fix that instead of using const_cast here? Seems horrible ;)
https://reviews.llvm.org/D23828


Repository:
  rL LLVM

https://reviews.llvm.org/D23279





More information about the cfe-commits mailing list