[PATCH] D23279: clang-reorder-fields

[Alexander Shaposhnikov via cfe-commits]

alexshap added inline comments.

================
Comment at: clang-reorder-fields/tool/ClangReorderFields.cpp:44
@@ +43,3 @@
+  bool parse(cl::Option &O, StringRef ArgName, const std::string &ArgValue,
+             SmallVector<std::string, 4> &Val) {
+    Val.clear();
----------------
djasper wrote:
> Don't use and output parameter. Just return Parts.
no, struct FieldsOrderParser will be passed to a template which expects it to implement this method (with this signature).
http://llvm.org/docs/CommandLine.html#writing-a-custom-parser
see "Writing a custom parser"


Repository:
  rL LLVM

https://reviews.llvm.org/D23279