[PATCH] D23820: Do not warn about format strings that are indexed string literals.

Stephen Hines via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 23 16:57:30 PDT 2016


srhines added inline comments.

================
Comment at: lib/Sema/SemaChecking.cpp:3856
@@ -3855,3 +3855,3 @@
 // format string, we will usually need to emit a warning.
 // True string literals are then checked by CheckFormatString.
 static StringLiteralCheckType
----------------
It might be good to mention that Offset now goes back to the caller to allow for checking of string literal suffixes.

================
Comment at: lib/Sema/SemaChecking.cpp:3900
@@ +3899,3 @@
+    // We need to maintain the offsets for the right and the left hand side
+    // seperately to check if every possible indexed expression is a valid
+    // string literal. They might have different offsets for different string
----------------
separately


https://reviews.llvm.org/D23820





More information about the cfe-commits mailing list