[PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

Tim Shen via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 22 12:59:09 PDT 2016


timshen added inline comments.

================
Comment at: llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h:684-688
@@ -684,7 +683,7 @@
     typedef SUnitIterator ChildIteratorType;
-    static inline NodeType *getEntryNode(SUnit *N) { return N; }
-    static inline ChildIteratorType child_begin(NodeType *N) {
+    static inline NodeRef getEntryNode(SUnit *N) { return N; }
+    static inline ChildIteratorType child_begin(NodeRef N) {
       return SUnitIterator::begin(N);
     }
-    static inline ChildIteratorType child_end(NodeType *N) {
+    static inline ChildIteratorType child_end(NodeRef N) {
       return SUnitIterator::end(N);
----------------
dblaikie wrote:
> If you like you could probably (separate commit) drop the 'inline' from these functions, they're implicitly inline anyway
Sure, I can do that in a following patch.


https://reviews.llvm.org/D23730





More information about the cfe-commits mailing list