[PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

Tim Northover via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 19 13:29:45 PDT 2016


t.p.northover added inline comments.

================
Comment at: test/Driver/arm-cortex-cpus.c:306
@@ -305,2 +305,3 @@
 // RUN: %clang -target arm -mcpu=bogus -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-BOGUS-CPU %s
+// RUN: %clang -arch arm64 -mcpu=bogus -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-BOGUS-CPU %s
 // CHECK-BOGUS-CPU: error: {{.*}} does not support '-mcpu=bogus'
----------------
I think these lines are relying on a Darwin host. -arch isn't a supported option on Linux & elsewhere and Clang will use its default triple. So you probably also need to specify a "-target" to put the driver into Darwin mode.

Either way, please make sure it's tested on a different platform before committing.


https://reviews.llvm.org/D23643





More information about the cfe-commits mailing list