Upgrade and fix clang-format-vs

Hans Wennborg via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 18 16:37:54 PDT 2016


Hi Antonio,

On Wed, Aug 17, 2016 at 8:15 AM, Antonio Maiorano via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> This patch for clang-format-vs includes the following:
>
> - Upgrade to VS 2015, including .NET framework upgrade from 4.0 to 4.5, and
> upgrading Microsoft.VisualStudio references to v14 versions
> - Fix build by removing dependency on "Key.snk" file which was never checked
> in (and not really required anyway)
> - Add ".vs" directory to svn ignore (new folder that VS 2015 creates for
> user settings)

"What does "Upgrade to VS 2015 mean? Adding support for running the
plugin in VS2015, or does it mean requiring VS2015 for building?

+zturner: I thought the plugin already worked in VS 2015?

I mostly just build the plugin without knowing exactly how this stuff
works, but looking at the patch I'm worried that you're increasing the
required version for building it? I see a bunch of values going from
10 (VS 2012) to 14 (VS 2015).

Thanks,
Hans


More information about the cfe-commits mailing list