[PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 18 08:27:58 PDT 2016


Anastasia added inline comments.

================
Comment at: lib/CodeGen/CGExprScalar.cpp:1513
@@ -1512,2 +1512,3 @@
     // extension.
-    llvm::Type *MiddleTy = CGF.IntPtrTy;
+    auto DestLLVMTy = ConvertType(DestTy);
+    llvm::Type *MiddleTy = CGF.CGM.getDataLayout().getIntPtrType(DestLLVMTy);
----------------
Did you miss this changes in the original patch then?

================
Comment at: lib/CodeGen/CGExprScalar.cpp:2447
@@ -2443,3 +2446,3 @@
     bool isSigned = indexOperand->getType()->isSignedIntegerOrEnumerationType();
-    index = CGF.Builder.CreateIntCast(index, CGF.PtrDiffTy, isSigned,
+    index = CGF.Builder.CreateIntCast(index, DL.getIntPtrType(PtrTy), isSigned,
                                       "idx.ext");
----------------
No longer ptrdiff_t?


https://reviews.llvm.org/D23361





More information about the cfe-commits mailing list