[PATCH] D23651: [clang-rename] improve performance for rename-all

Alexander Shaposhnikov via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 18 04:00:03 PDT 2016


alexshap added a subscriber: alexshap.

================
Comment at: clang-rename/USRFindingAction.h:38
@@ -37,5 +37,3 @@
 private:
-  unsigned SymbolOffset;
-  std::string OldName;
-  std::string SpellingName;
-  std::vector<std::string> USRs;
+  std::vector<unsigned> SymbolOffsets;
+  std::vector<std::string> OldNames;
----------------
in the constructor SymbolOffsets, OldNames are passed by non-constant reference
but then you make a copy.  


https://reviews.llvm.org/D23651





More information about the cfe-commits mailing list