[PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix
Piotr Padlewski via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 16 15:37:40 PDT 2016
Prazek added inline comments.
================
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+ hasDeclaration(decl(anyOf(isPrivate(), isProtected())))))));
+
----------------
aaron.ballman wrote:
> Perhaps: `unless(isPublic())` instead of `anyOf(isPrivate(), isProtected())`?
POD types doesn't have public constructors so it will fail :)
https://reviews.llvm.org/D23343
More information about the cfe-commits
mailing list