[PATCH] D23544: [clang-tidy] readability-implicit-bool-cast forgets to store its options.
Haojian Wu via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 16 03:01:43 PDT 2016
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D23544
Files:
clang-tidy/readability/ImplicitBoolCastCheck.cpp
clang-tidy/readability/ImplicitBoolCastCheck.h
Index: clang-tidy/readability/ImplicitBoolCastCheck.h
===================================================================
--- clang-tidy/readability/ImplicitBoolCastCheck.h
+++ clang-tidy/readability/ImplicitBoolCastCheck.h
@@ -28,6 +28,7 @@
Options.get("AllowConditionalIntegerCasts", 0) != 0),
AllowConditionalPointerCasts(
Options.get("AllowConditionalPointerCasts", 0) != 0) {}
+ void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
Index: clang-tidy/readability/ImplicitBoolCastCheck.cpp
===================================================================
--- clang-tidy/readability/ImplicitBoolCastCheck.cpp
+++ clang-tidy/readability/ImplicitBoolCastCheck.cpp
@@ -299,6 +299,14 @@
} // anonymous namespace
+void ImplicitBoolCastCheck::storeOptions(
+ ClangTidyOptions::OptionMap &Opts) {
+ Options.store(Opts, "AllowConditionalIntegerCasts",
+ AllowConditionalIntegerCasts);
+ Options.store(Opts, "AllowConditionalPointerCasts",
+ AllowConditionalPointerCasts);
+}
+
void ImplicitBoolCastCheck::registerMatchers(MatchFinder *Finder) {
// This check doesn't make much sense if we run it on language without
// built-in bool support.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23544.68150.patch
Type: text/x-patch
Size: 1382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160816/a2305c55/attachment.bin>
More information about the cfe-commits
mailing list