[PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 15 15:42:31 PDT 2016


jlebar added a comment.

Wow, I have no idea if this is right.  I can try to figure it out, but if sfantao can review, that's easier.


================
Comment at: test/Driver/cuda-bindings.cu:10
@@ +9,3 @@
+// way. Instead we check whether we've generated a permanent name on
+// device side which appends '-device-cuda-<triple>' suffix.
+
----------------
Nonrestrictive subordinating clause, comma before "which".

================
Comment at: test/Driver/cuda-bindings.cu:60
@@ +59,3 @@
+//
+// Test two gpu architecturess up to the assemble phase.
+//
----------------
Spelling


https://reviews.llvm.org/D23526





More information about the cfe-commits mailing list