[PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 14 13:22:59 PDT 2016


EricWF marked an inline comment as done.

================
Comment at: lib/Sema/SemaDecl.cpp:10528
@@ +10527,3 @@
+                                    var->getLocation())) {
+      // Warn about globals which don't have a constant initializer.  Don't
+      // warn about globals with a non-trivial destructor because we already
----------------
EricWF wrote:
> I can't figure out where the diagnostic is this comment is coming from. Hopefully I'm just missing something simple.
Nevermind, I kept reading "global destructor" as "global constructor" and was looking for the wrong thing.


https://reviews.llvm.org/D23385





More information about the cfe-commits mailing list